Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppc64le to CI and fix node20 breakage #630

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Add ppc64le to CI and fix node20 breakage #630

wants to merge 4 commits into from

Conversation

mborland
Copy link
Member

@mborland mborland commented Jul 8, 2024

No description provided.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (1a06c2e) to head (366a6bc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #630   +/-   ##
=======================================
  Coverage     94.1%   94.1%           
=======================================
  Files          276     276           
  Lines        26846   26846           
=======================================
  Hits         25240   25240           
  Misses        1606    1606           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a06c2e...366a6bc. Read the comment docs.

@mborland
Copy link
Member Author

mborland commented Jul 9, 2024

@jzmaddock, @ckormanyos, @NAThompson before I merge this in do you see adding PPC64LE to our CI as valuable? The tradeoff is that it increases the CI run time to about 4 hours. It's not a super high demand architecture but I know in math, charconv, and others there are occasional bug reports.

@jzmaddock
Copy link
Collaborator

I guess it's main use is as a "different" architecture. Other than that I'm guessing is basically obsolete now?

@mborland
Copy link
Member Author

I guess it's main use is as a "different" architecture. Other than that I'm guessing is basically obsolete now?

Yes it's little endian with two different 128-bit long double ABIs (__ibm128 and __float128) depending on which OS/compiler you are using. I don't think it's obsolete just really expensive. I got a quote for what it would cost to run natively in Drone like ARM and s390x, and it was prohibitive.

@jzmaddock
Copy link
Collaborator

Yes it's little endian with two different 128-bit long double ABIs (__ibm128 and __float128) depending on which OS/compiler you are using. I don't think it's obsolete just really expensive. I got a quote for what it would cost to run natively in Drone like ARM and s390x, and it was prohibitive.

Understood. Many many moon ago, when some hardware vendors provided "compiler farms" you could telnet into, I wondered if it wouldn't be possible to persuade some of them to donate some older machines to the project... but then I realised that someone would have to actually make space for them, put up with the noise and the heat, and feed them actual electrons!

If we (or rather Vinnie) were going to spend actual $$'s, then I suspect providing a CUDA-enabled test machine might be the thing to spend it on. It's also rather niche, but increasingly important IMO?

@mborland
Copy link
Member Author

Yes it's little endian with two different 128-bit long double ABIs (__ibm128 and __float128) depending on which OS/compiler you are using. I don't think it's obsolete just really expensive. I got a quote for what it would cost to run natively in Drone like ARM and s390x, and it was prohibitive.

Understood. Many many moon ago, when some hardware vendors provided "compiler farms" you could telnet into, I wondered if it wouldn't be possible to persuade some of them to donate some older machines to the project... but then I realised that someone would have to actually make space for them, put up with the noise and the heat, and feed them actual electrons!

If we (or rather Vinnie) were going to spend actual $$'s, then I suspect providing a CUDA-enabled test machine might be the thing to spend it on. It's also rather niche, but increasingly important IMO?

I can ask about some CUDA machines as that would be quite useful. You also can't emulate CUDA so it has to run native.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants