Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inverse function for affine matrix3x2 #527

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

sdebionne
Copy link
Contributor

@sdebionne sdebionne commented Nov 4, 2020

Description

Adds inverse(boost::gil::matrix3x2<T> m) that returns the inverse of the given affine matrix to the numeric extension. This is useful to implement an undo of an affine transformation or to compute the coordinate of points in the original coordinate system gievn the coordinate in transformed one.

Use BOOST_TEST_WITH and defines with_tolerance rather BOOST_GIL_TEST_IS_CLOSE as discussed in boostorg/core#38

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@mloskot mloskot added cat/feature New feature or functionality ext/numeric boost/gil/extension/numeric/ labels Nov 4, 2020
@mloskot mloskot added this to the Boost 1.75+ milestone Nov 4, 2020
@mloskot mloskot assigned mloskot and unassigned mloskot Nov 4, 2020
@sdebionne sdebionne force-pushed the add-numeric-matrix-inverse branch from 67b99c3 to 36279f3 Compare November 5, 2020 10:34
@mloskot mloskot modified the milestones: Boost 1.75, Boost 1.76+ Nov 10, 2020
@sdebionne
Copy link
Contributor Author

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

@mloskot Before re-running all the pipelines because one single little tiny travis stalled job, is there a way, as maintainers, to trigger a re-build of a specific job? Just to save the polar bears (and more) from climate change...

@mloskot
Copy link
Member

mloskot commented Nov 10, 2020

@sdebionne Good thinking! Yes, there is a way and, I think, as a committer you are authorized to do it:

  1. Go to https://travis-ci.org/github/boostorg/gil
  2. Sign in using GitHub
  3. Hit the gray circle next to the job to re-run it

image

Unfortunately, this is not possible for AppVeyor, because AV does not seem to transfer the privileges from GitHub but it is owned by account used to create it, namely @stefanseefeld

That is another reason I'd like to switch everything over to GitHub Actions, to streamline the CI chore as accessible across our team.

@sdebionne
Copy link
Contributor Author

Unfortunately I don't have the gray circle next to the job. Maybe some configuration on the travis side is required?

That is another reason I'd like to switch everything over to GitHub Actions, to streamline the CI chore as accessible across our team.

I don't much about GitHub Actions but if it makes the CI more accessible then 👍

@sdebionne
Copy link
Contributor Author

@mloskot My bad, login out and back in fixed the permissions! Thanks for the tip.

@mloskot mloskot merged commit 68cdbdd into boostorg:develop Jan 20, 2021
@mloskot
Copy link
Member

mloskot commented Jan 20, 2021

Sorry for ridiculous delay, but I completely missed this PR. Thanks!

meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 21, 2021
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 22, 2021
@sdebionne sdebionne deleted the add-numeric-matrix-inverse branch May 4, 2022 06:50
@mloskot mloskot mentioned this pull request May 12, 2022
6 tasks
mloskot added a commit that referenced this pull request Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/feature New feature or functionality ext/numeric boost/gil/extension/numeric/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants