Implement hstack and vstack #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejaeger
reviewed
Jul 14, 2020
There was a problem hiding this comment.
@simmplecoder I just made a few tiny comments. Apart from that, for the purpose of stacking image views it looks fine.
mloskot
requested changes
Aug 24, 2020
|
@mloskot it is a convenience tool to make putting input and result in perspective easier. It could use a lot of work, but I thought we could do by it for GSoC. Anyway, this is not really needed, but would be a good addition until a better way is found. |
|
@simmplecoder Sounds good. Let's consider it as part of GSoC as part of the whole toolkit. Could you address @codejaeger 's suggestions? |
|
@mloskot , sure, will ping you back when ready. |
Width can be different in hstack, height can be different in vstack
meshtag
pushed a commit
to meshtag/gil
that referenced
this pull request
Apr 21, 2021
Allow non-equal dims along stack dim Width can be different in hstack, height can be different in vstack
meshtag
pushed a commit
to meshtag/gil
that referenced
this pull request
Apr 22, 2021
Allow non-equal dims along stack dim Width can be different in hstack, height can be different in vstack
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds ability to stack images either horizontally or vertically. Provides output view argument form and image returning form for convenience. Does full input checking. This is rough version only, not intended for usage outside writing examples.
References
https://cpplang.slack.com/archives/CSVT0STV2/p1594414134118400
Tasklist