Use perfect forwarding from apply_operation to visit #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
added
ext/dynamic_image
|
I'm not sure myself, but perhaps you have checked @sdebionne if there is anything in the tests that calls these, is there? |
|
Since boostorg/variant2#20 is already implemented, I need to revisit this MR! I'll check the tests as well... |
sdebionne
force-pushed
the
add-apply-operation-overloads
branch
from
d5e1925 to
d400a78
Compare
sdebionne
changed the title
|
@sdebionne Could you let me know if this is ready to review and merge. It's been a while and I might have missed any update |
|
@mloskot Sorry I forgot to update the state from draft to ready to review. |
simmplecoder
pushed a commit
to simmplecoder/gil
that referenced
this pull request
Jun 24, 2020
Manually confirmed the changes have been verified by the dynamic_image tests ~@mloskot
mloskot
added a commit
that referenced
this pull request
Jul 11, 2020
* develop: Collect release notes for Boost 1.74 Fix missing header in numeric/kernel.hpp to make it self-contained (#502) Use perfect forwading from apply_operation to visit (#491) Fix typos and replace mpl with mp11 in tutorial (#494) Implemented mechanism to reverse kernel_2d (#489) added missing const& in extend_boundary parameters (#490) Add initializing image constructor (#486) Fix interleaved_view factory using point<std::ptrdiff_t> for dimension (#487) RELEASES.md: Remove beta tag [ci skip] Replace Boost.Variant with Boost.Variant2 (#474) Fix error plane_view_t is not a class or namespace name (#481) Fix image constructor from other image (#477) Fix overflow in RGB to CMYK32 conversion (#470)
2 tasks
mloskot
pushed a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a couple of overloads of
apply_operationfor binary operations. This is necessary until boostorg/variant2#20 is implemented. At that pointapply_operationwon't be necessary anymore (or could perfect forward tovisit).Tasklist