Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add any_image_view::size() #456

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Add any_image_view::size() #456

merged 1 commit into from
Mar 20, 2020

Conversation

sdebionne
Copy link
Contributor

@sdebionne sdebionne commented Mar 19, 2020 •
edited by mloskot
Loading

Description

Adds any_image_view::size() that returns the size of the underlying image_view.

size_type        View::size()       const; // total number of elements

Tasklist

  • Add test case(s)
  • Update doc(s)
  • Ensure all CI builds pass
  • Review and approve

@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs ext/dynamic_image boost/gil/extension/dynamic_image labels Mar 19, 2020
mloskot
mloskot approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although I'm not a heavy user of dynamic_image, I don't see this may introduce any breakages or problems. I think it just completes the interface. If no objections arrive soon from @stefanseefeld, @lpranam , @chhenning or anyone else active/interested in GIL, then I'll merge it.

@sdebionne Thank you for the contribution.

@mloskot mloskot self-assigned this Mar 19, 2020
@mloskot mloskot added this to the Boost 1.73 milestone Mar 19, 2020
lpranam
lpranam approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me :)

@sdebionne
Copy link
Contributor Author

Yeah, it's not really a life-changing PR :-)

@mloskot mloskot merged commit c036059 into boostorg:develop Mar 20, 2020
@sdebionne sdebionne deleted the add-any-image-view-size branch October 14, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

@lpranam lpranam lpranam approved these changes

@stefanseefeld stefanseefeld Awaiting requested review from stefanseefeld

Assignees

@mloskot mloskot

Labels
cat/enhancement Improvements, but not fixes addressing identified bugs ext/dynamic_image boost/gil/extension/dynamic_image
Projects
None yet
Milestone
Boost 1.73
Development

Successfully merging this pull request may close these issues.
3 participants
@sdebionne @mloskot @lpranam