Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value-initialize channel and pixel value members #273

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Value-initialize channel and pixel value members #273

merged 1 commit into from
Apr 1, 2019

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Mar 30, 2019 •
edited
Loading

Add tests to ensure member values of channel and pixel classes are determined, zero-initialized.

Tidy up formatting.

References

Fixes #270

Tasklist

  • Add test case(s)
  • Review
  • Adjust for comments
  • All CI builds and checks have passed

@mloskot
Value-initialize channel and pixel value members
88a932c 
Add tests to ensure member values of channel and pixel classes are
determined, zero-initialized.
Fixes boostorg#270

Tidy up formatting.
@mloskot mloskot added cat/bug But reports and bug fixes cat/refactoring Any nonfunctional changes core boost/gil labels Mar 30, 2019
@mloskot mloskot self-assigned this Mar 30, 2019
@mloskot mloskot requested a review from stefanseefeld March 30, 2019 00:06
@mloskot mloskot added this to the Boost 1.71 milestone Mar 30, 2019
@mloskot mloskot merged commit c6c5336 into boostorg:develop Apr 1, 2019
@mloskot mloskot deleted the ml/fix-default-initialization-in-pixel-classes branch April 1, 2019 16:19
@mloskot mloskot mentioned this pull request Apr 1, 2019
Merged
3 tasks
@mloskot mloskot mentioned this pull request Jan 21, 2021
Merged
3 tasks
mloskot added a commit that referenced this pull request Jan 22, 2021
@mloskot
Fix default ctor of homogeneous_color_base for reference pixel elemen…
470923b 
…ts (#542)

If `Element` is a reference, then Element v{} is ill-formed.

Refines #273 which aimed to correctly value-initialize channel and pixel value members
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 21, 2021
@mloskot @meshtag
Fix default ctor of homogeneous_color_base for reference pixel elemen…
a653a0a 
…ts (boostorg#542)

If `Element` is a reference, then Element v{} is ill-formed.

Refines boostorg#273 which aimed to correctly value-initialize channel and pixel value members
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 22, 2021
@mloskot @meshtag
Fix default ctor of homogeneous_color_base for reference pixel elemen…
620ec4b 
…ts (boostorg#542)

If `Element` is a reference, then Element v{} is ill-formed.

Refines boostorg#273 which aimed to correctly value-initialize channel and pixel value members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanseefeld stefanseefeld stefanseefeld approved these changes

Assignees

@mloskot mloskot

Labels
cat/bug But reports and bug fixes cat/refactoring Any nonfunctional changes core boost/gil
Projects
None yet
Milestone
Boost 1.72
Development

Successfully merging this pull request may close these issues.
2 participants
@mloskot @stefanseefeld