Fix/get turn info collinear #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intersection point
vissarion
approved these changes
Jan 11, 2021
| return false; | ||
| } | ||
|
|
||
| auto const location = distance_measure(info.intersections[1], |
Member
There was a problem hiding this comment.
regarding the name location maybe distance_from_location or something is more relevant since this is not a location but some kind of distance.
Collaborator
Author
There was a problem hiding this comment.
Agreed, I don't know why I took location. I will change it, and merge. Thanks for your review.
Collaborator
Author
There was a problem hiding this comment.
In other places I used dm for this purpose so I use that now here too.
barendgehrels
force-pushed
the
fix/get-turn-info-collinear
branch
from
8a4a79e to
d006d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles, in rare cases, collinear as if it was equal, because the arriving segment arrives at the intersection point in the same way as it is in equal (but at an undetectable distance).
In terms of statistics this reduces the error count from 444 to 241 (in recursive_polygons_buffer)
There are several tests added, some of them are fixed by this test, some remain to be fixed but it's more convenient to have them in this PR already.
There is also a bit cleanup in get_turn_info in the same way I added the new code.