-
Notifications
You must be signed in to change notification settings - Fork 223
Define CS-specific behavior of algorithms only with strategy (part 2). #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I am ok with merging.
@@ -453,7 +476,7 @@ class is_valid_polygon | |||
// compute turns and check if all are acceptable | |||
debug_phase::apply(3); | |||
|
|||
typedef has_valid_self_turns<Polygon> has_valid_turns; | |||
typedef has_valid_self_turns<Polygon, typename Strategy::cs_tag> has_valid_turns; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not typedef
ed as above or not typedef
the above to look alike. Similar cases below. Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there is no specific cause. I think I prefer removing typedef
above because it's used only in one place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It is huge, and I could not check all details, but what I've seen looks to me. So I'm OK with merging this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think I'll also add some tests for geometries with undefined CS before merging.
…to get envelope and expand strategies.
…nce_insert and sym_difference_insert.
98d494d
to
b73a401
Compare
I addressed the issue raised by @vissarion, resolved the conflict with develop, added tests and fixed one more issue, i.e. passed the strategy into |
572f36a
to
4a279fe
Compare
Followup of #533
The changes:
bgi::parameters<RtreeParams, Strategy>
, not all possible operations are supported, only those required by other algorithms where the rtree is used, for other operations the default strategy is used as it was before. This needs further changes but I think it needs more general changes in strategies, i.e. introduction of "proper" umbrella strategies.