Work around incomplete closure input arguments on some platforms#817
Closed
rosenrodt wants to merge 1 commit intoboostorg:developfrom
Closed
Work around incomplete closure input arguments on some platforms#817rosenrodt wants to merge 1 commit intoboostorg:developfrom
rosenrodt wants to merge 1 commit intoboostorg:developfrom
Conversation
Contributor
|
That's odd that such an old function works incorrectly ( |
Contributor
Author
|
Thank @jszuppe. I have opened a ticket here see how this goes boostorg/algorithm#58 |
on some platforms trim() would cut off function argument names in the CL kernel declaration and therefore breaks custom closures; the functionality is replaced by split() to circumvent this issue
eb93c24 to
73d978b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all the kernel compile errors I encountered when running
test_closure, one example:I encountered this curious case when cross-compiling with the standalone toolchain generated from android NDK. Most tests pass. But closure is among one of the few that fails. It seems like boost::trim() from the main boost library somehow cuts off more character than it should and also leaves a leading whitespace.