Fix stage target to not use undefined BOOST_STAGE_LOCATE #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opinion on this @vprus? |
pdimov
force-pushed
the
pdimov-patch-2
branch
from
a100fbd to
f1fb8a8
Compare
pdimov
force-pushed
the
pdimov-patch-2
branch
from
f1fb8a8 to
33704a3
Compare
pdimov
added a commit
that referenced
this pull request
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOOST_STAGE_LOCATEis undefined inboost-install, so it always uses the target name,stage. This means that whenb2 stageis invoked from, f.ex.libs/system/build, a locallibs/system/build/stagedirectory is used for staging. This is almost certainly wrong. In addition,BOOST_STAGE_LOCATEinboostcppis by default the relative pathstage, so even if used withmodules.peek, it works the same way.I'm not entirely sure that the proposed replacement is correct in all use cases, but it's an improvement. :-)