Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOST-652] Implement skeleton for azure-infrastructure #197

Merged
merged 7 commits into from
Jun 12, 2020

Conversation

MarcAstr0
Copy link
Collaborator

Description

Implement skeleton for azure-infra package

Changes

Tested locally so that when running a boost deploy we will deploy a resource group and a storage account.

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly at the docs repo
  • Added a link pointing to the documentation PR in this PR

Additional information

rdoria1 and others added 6 commits May 28, 2020 14:29
- Implement skeleton for azure-infrastructure
- Implement skeleton for azure-infrastructure
- Addressed some comments.
Templates for Function App and API Management were added
Copy link
Contributor

@rdiaz82 rdiaz82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Itis weird, check the linters because they failed

@rdiaz82 rdiaz82 self-requested a review June 11, 2020 16:27
@MarcAstr0
Copy link
Collaborator Author

MarcAstr0 commented Jun 11, 2020

Itis weird, check the linters because they failed

It fails because it can't bootstrap the project:

npx: installed 753 in 36.985s
lerna notice cli v3.22.1
lerna info ci enabled
lerna info bootstrap root only
yarn install v1.22.4
[1/4] Resolving packages...
error Couldn't find any versions for "@boostercloud/framework-provider-azure" that matches "^0.3.3"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
warning workspace-aggregator-3075625d-b301-46b3-ac47-b6de6e6ee8d5 > @boostercloud/framework-provider-azure-infrastructure > ms-rest-azure > adal-node > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
lerna ERR! yarn install --mutex network:42424 --non-interactive exited 1 in 'root'
lerna ERR! yarn install --mutex network:42424 --non-interactive exited 1 in 'root'
##[error]Process completed with exit code 1.

Versioning fixes
@MarcAstr0 MarcAstr0 requested a review from rdiaz82 June 11, 2020 17:03
Copy link
Contributor

@rdiaz82 rdiaz82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rdiaz82
Copy link
Contributor

rdiaz82 commented Jun 11, 2020

bot: integration

@MarcAstr0 MarcAstr0 merged commit 98b2d6a into master Jun 12, 2020
@MarcAstr0 MarcAstr0 deleted the BOOST-652-skeleton-azure-infra branch June 12, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants