Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getters not working when return type is a promise of an array of… #1557

Conversation

hendrik-depauw-lemon
Copy link
Contributor

… objects

Description

Changes

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

Copy link

what-the-diff bot commented Nov 4, 2024

PR Summary

  • Improved Handling of Promises in Source Data
    • The code now checks if a certain value (source[key]) is a Promise. If it is, the code will wait for it to resolve before it proceeds. This ensures that all data is properly processed, even if it's delivered in the form of a Promise, enhancing the reliability of the code.

Copy link
Member

@javiertoledo javiertoledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrik-depauw-lemon
Copy link
Contributor Author

Can we get this merged? 🙂

@davidverdu
Copy link
Collaborator

@hendrik-depauw-lemon you also need to add the changeset file. Please run rush change and commit the changeset file

@davidverdu
Copy link
Collaborator

Hi @hendrik-depauw-lemon it seems that rush change generated a file that is not appealing to the GitHub action that checks it. Could you do these steps and regenerate the change file?

  • ensure you have run in your local repository git remote add boostercloud https://github.com/boostercloud/booster.git, so that no warnings are displayed at executing rush change
  • ensure you have rebased to the latest changes of the main repository

@hendrik-depauw-lemon
Copy link
Contributor Author

I updated it, hopefully it's ok now

@davidverdu
Copy link
Collaborator

/integration sha=df03afe

Copy link
Contributor

⌛ Integration tests are running...

Check their status here 👈

Copy link
Contributor

✅ Integration tests have finished successfully!

@davidverdu davidverdu merged commit 389dbf7 into boostercloud:main Dec 17, 2024
6 checks passed
@davidverdu
Copy link
Collaborator

@hendrik-depauw-lemon merged!! Thank you for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants