-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read model queries when selecting deeply-nested arrays #1552
Conversation
PR Summary
|
/integration sha=b094289 |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
/integration sha=6813d46 |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But Integration tests should pass as well
/integration sha=bc7438a |
⌛ Integration tests are running... Check their status here 👈 |
❌ Oh no! Integration tests have failed |
/integration sha=cacf3df |
⌛ Integration tests are running... Check their status here 👈 |
✅ Integration tests have finished successfully! |
Description
The changes in this PR fix some issues when selecting fields in read model objects that are nested deeply. Previously, if one were to select a field from an object in an array nested deeper than a top-level property, e.g.,
['foo.bar.arr[].id']
, it would generate the wrong SQL code. To keep things simple, when this case is encountered, it will retrieve all the properties of the objects in the array.Changes
buildProjections
and add apreprocessProjections
method to the Cosmos query helper to identify and alter the projections with deeply nested arrays.Checks