Feature #71 - LotusList 페이지 구현 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 추후 loading, error fallback 변경 필요
- 추후에 query key 관리 방법 변경 필요
naarang
approved these changes
Nov 17, 2024
| const url = new URL(request.url); | ||
| const page = url.searchParams.get('page'); | ||
| const size = url.searchParams.get('size'); | ||
| const search = url.searchParams.get('search'); |
There was a problem hiding this comment.
public lotus 목록 조회에서 search는 우선 제외한 건가요??
There was a problem hiding this comment.
넹 search는 일단 빼두고 작업했습니당
| import { LotusType } from './type'; | ||
|
|
||
| export const getLotusList = async ({ page = 1 }: { page: number }) => { | ||
| const res = await fetch(`/api/lotus?page=${page}`); |
There was a problem hiding this comment.
저희는 fetch랑 axios 중에 fetch로 쓰나용? axios 사용해봐도 좋을 것 같아서요!
| }); | ||
|
|
||
| export const Route = createFileRoute('/(main)/lotus/')({ | ||
| validateSearch: (search) => lotusSearchValidation.parse(search) |
There was a problem hiding this comment.
아까 슬랙에 글 올려주신 내용이네요! 저도 처음 알았습니다ㅠㅠ 감사해요!🙇♀️
There was a problem hiding this comment.
저도 이거 때문에... 고생을 좀,...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#71
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)
네이밍이 이상하거나 이해가 가지 않는 부분 모두 코멘트 남겨주세요!
모킹은 순차적으로 동적으로 변경해볼 예정입니다.
파일 경로나 query-key 구조화 같은 경우에는 추후에 정리가 필요해보입니다.