[FEAT/#72] 스티커 바텀 시트 추가 및 스티커 선택 추가 기능 구현 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com> Co-Authored-By: Youngkyu Song <ace_lephant@naver.com> Co-Authored-By: seuhong <66902876+hsw1920@users.noreply.github.com>
- 중간, 최대로 뜰 수 있도록 수정
- 이미지가 올라올 영역은 빨간색으로 표시 - 하프모달과 fullModal 둘 다 되도록 설정 - 영역 체크를 위해 설정해둔 임시 컬러들을 제거
Closed
Collaborator
Author
습관성 Co-Auth ㅋㅋㅋ |
3 tasks
youn9k
reviewed
Nov 26, 2024
...ayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/EditPhotoRoomGuestViewController.swift
Show resolved
Hide resolved
youn9k
reviewed
Nov 26, 2024
...ayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/EditPhotoRoomGuestViewController.swift
Outdated
Show resolved
Hide resolved
youn9k
reviewed
Nov 26, 2024
...Layer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/EditPhotoRoomHostViewController.swift
Show resolved
Hide resolved
youn9k
reviewed
Nov 26, 2024
...ationLayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/EditPhotoRoomHostViewModel.swift
Outdated
Show resolved
Hide resolved
youn9k
reviewed
Nov 26, 2024
...ayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/StickerBottomSheetViewController.swift
Outdated
Show resolved
Hide resolved
youn9k
reviewed
Nov 26, 2024
...ayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/StickerBottomSheetViewController.swift
Outdated
Show resolved
Hide resolved
youn9k
reviewed
Nov 26, 2024
...tionLayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/StickerBottomSheetViewModel.swift
Show resolved
Hide resolved
hsw1920
approved these changes
Nov 26, 2024
Collaborator
hsw1920
left a comment
hsw1920
left a comment
There was a problem hiding this comment.
고생하셨습니다 ! 몇몇 부분만 수정 부탁드립니다.
...ayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/EditPhotoRoomGuestViewController.swift
Show resolved
Hide resolved
...ayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/StickerBottomSheetViewController.swift
Outdated
Show resolved
Hide resolved
...ayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/StickerBottomSheetViewController.swift
Show resolved
Hide resolved
...esentationLayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/StickerCollectionView.swift
Show resolved
Hide resolved
youn9k
reviewed
Nov 26, 2024
...tationLayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/StickerCollectionViewCell.swift
Show resolved
Hide resolved
youn9k
reviewed
Nov 26, 2024
Member
youn9k
left a comment
youn9k
left a comment
There was a problem hiding this comment.
궁금한 부분들 코멘트 몇개 달아뒀어요! 고생하셨씁니다ㅎㅎ
Kiyoung-Kim-57
approved these changes
Nov 26, 2024
...ayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/StickerBottomSheetViewController.swift
Outdated
Show resolved
Hide resolved
- delegate 순환 참조 방지
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
📃 작업 내역
✅ 리뷰 노트
emojiList와 관련된 코드의 일부를
StickerBottomSheetViewController와StickerBottomSheetViewModel로 옮겨왔습니다.총 두번의 delegate 패턴을 사용하게 되는데, 혹시라도 현재 구현된 방식이 팀의 MVVM + Combine 패턴에 맞지 않다면 말씀주시면 감사하겠습니다!
🎨 스크린샷
🚀 테스트 방법
EditPhotoRoomFeatureDemo를 실행 해주세요