[FEAT/#96] Offer 관련 개발환경 개선 #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Demo 개발 시 Offer를 담당하는 뷰를 구현하였습니다. Co-Authored-By: YeongHoon Song <37678646+0Hooni@users.noreply.github.com>
Co-Authored-By: YeongHoon Song <37678646+0Hooni@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
EditPhotoFeatureDemo 개발 시 Guest와 Host의 커넥션연결을 위해 필요 없는 의존성을 가지고 있었습니다.
이를 분리하고자 DemoApp에서만 사용하는 SendOffer 를 요청하는 임시 뷰가 필요했습니다.
📃 작업 내역
SendOfferTempViewController구현EditPhotoRoomFeature의ViewController에서 필요없는SendOfferUseCase제거✅ 리뷰 노트
개발 환경 개선을 위한 작업이며 Debug에서만 활용하여 실제 release될 부분이 아니기 때문에 특별히 리뷰하실 부분은 없습니다.
🎨 스크린샷
🚀 테스트 방법
EditPhotoFeatureDemoApp을 실행하면 됩니다.