[FEAT/#47] 이벤트 허브를 만든다 #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nil인 경우가 존재할 수 있음 Co-Authored-By: YeongHoon Song <37678646+0Hooni@users.noreply.github.com>
Co-Authored-By: YeongHoon Song <37678646+0Hooni@users.noreply.github.com>
Co-Authored-By: seuhong <66902876+hsw1920@users.noreply.github.com>
- 추후 Priority Queue로 최적화 예정 Co-Authored-By: YeongHoon Song <37678646+0Hooni@users.noreply.github.com>
Co-Authored-By: YeongHoon Song <37678646+0Hooni@users.noreply.github.com>
Co-Authored-By: seuhong <66902876+hsw1920@users.noreply.github.com>
…er into feat/#47-make-event-hub
Co-Authored-By: seuhong <66902876+hsw1920@users.noreply.github.com>
Closed
3 tasks
0Hooni
commented
Nov 23, 2024
| let point: CGPoint | ||
| let size: CGSize | ||
| let scale: CGFloat | ||
| let owner: String |
Collaborator
Author
There was a problem hiding this comment.
id: 구별하기 위해
nickname: 중복될 수 있음
추후 오너에 대한 정보를 struct로 변경 필요
0Hooni
commented
Nov 23, 2024
...r/PresentationLayer/EditPhotoRoomFeature/EditPhotoRoomFeature/Source/EventHub/EventHub.swift
Show resolved
Hide resolved
Member
|
라이브 코드 리뷰 잘봤습니다ㅎㅎ |
Member
|
LGTM! 라이브 코드 리뷰 설명이 너무 좋아요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
📃 작업 내역
✅ 리뷰 노트
임시코드가 많아 넘어가는 부분으로 봐주세요
🎨 스크린샷
x
🚀 테스트 방법
x