[FEAT/#40] 방 생성 작업 2 진행중... #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
- 클라이언트 코드 그대로 가져와서 Encodable, Decodable만 반대로 바꿔줌 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- 구조체에서 클래스로 변환 - 불필요한 공백 제거 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- 테스트용 코드 작성 중입니다. Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- 리퀘스트의 타입을 먼저 디코딩해서 볼 수 있는 구조체를 구현하여 적용했습니다. Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- 생성자의 body -> message 수정 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- SignalingRequestDTO를 이용해 SDP, Candidate 정보를 래핑하여 Request 타입과 함께 전달합니다 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
- GetRemoteVideoUseCase와 GetRemoteVideoUseCaseImpl 구현 - GetLocalVideoUseCase와 GetLocalVideoUseCaseImpl rngus Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- 생성자 internal -> public 수정 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- SceneDelegate에서 UseCase와 Repository 생성해서 뷰모델에 주입해줬습니다 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
- 속성 이름이 달라 디코딩에러 발생해서 수정했습니다 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
- 시즌 1235125호 비디오 캡쳐 기능 추가 - 이번엔 연결 안된다고 안터져요 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
youn9k
commented
Nov 23, 2024
|
|
||
| public final class GetLocalVideoUseCaseImpl: GetLocalVideoUseCase { | ||
| public func execute() -> UIView { | ||
| connectionRepository.clients[0].localVideoView |
Member
Author
There was a problem hiding this comment.
추후 Repository에서 하나의 localVideoView만 들고있도록 할 예정입니다!
Collaborator
There was a problem hiding this comment.
추후 Client 프로퍼티에서 host/guest 여부와 닉네임을 알 수 있도록 하면 좋을 것 같습니다!
Member
Author
|
라이브 코드 리뷰 완료 (4/4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
📃 작업 내역
✅ 리뷰 노트
🎨 스크린샷
🚀 테스트 방법