[Feat/#61] 도메인에 위치했던 클라이언트들을 데이터로 이동시켰습니다 #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Signaling Client, WebRTC Client, Connection Client를 Data 모듈로 이동
- 기존 Domain과 DomainInterface를 의존하던 것을 수정했습니다 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- ConnecionClient Interface에서 채택하고 있던 Delegate를 이동하는 과정에서 제거했습니다. - 이에 따라 ConnectionClientImpl에서 명시적으로 Delegate들을 채택했습니다. Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- 임시로 Clients의 수를 제공하는 UseCase를 생성했습니다 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
- ConnectionClient Mock 생성 - ConnectionRepository Mock 생성 - CountClientsUseCase Mock 생성 Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
4 tasks
Co-Authored-By: Youngkyu Song <ace_lephant@naver.com>
컨플릭트를 해결하면서 의존성이 날아갔었음..
hsw1920
approved these changes
Nov 20, 2024
0Hooni
approved these changes
Nov 21, 2024
Collaborator
0Hooni
left a comment
0Hooni
left a comment
There was a problem hiding this comment.
LGTM 💯
좋은 리팩토링이네요!
사용성이 더 좋아진것 같아요 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
📃 작업 내역
아래 그림과 같이 기존(AS-IS)에서 현재 형태(TO-DO)로 구조를 바꿨습니다
데이터 모듈로 옮긴 ConnectionClient 객체들을 관리하는 ConnectionRepository를 생성했습니다
UseCase 적용을 위해 간단한 CountClientsUseCase를 생성했습니다.
UseCase 테스트를 위해 필요한 Mock 객체들과 UseCaseTests를 생성하고 테스트했습니다.
✅ 리뷰 노트
🎨 스크린샷
🚀 테스트 방법