Skip to content

서버 스펙 변경 Node.js -> Vapor #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2024
Merged

서버 스펙 변경 Node.js -> Vapor #6

merged 5 commits into from
Nov 7, 2024

Conversation

@youn9k
Copy link
Member

@youn9k youn9k commented Nov 7, 2024

🤔 배경

📃 작업 내역

  • 네이버 클라우드 인스턴스에 swift 6.0.2 설치
  • 네이버 클라우드 인스턴스에 make 설치
  • 네이버 클라우드 인스턴스에 vapor 설치
  • vapor 서버 배포

✅ 리뷰 노트

아래처럼 서버 IP를 0.0.0.0 으로 설정해야 서버에 연결이 되더라구요.
원래 이렇게 하는걸까요? 서버는 처음이라 진짜 모름..

public func configure(_ app: Application) async throws {
    app.http.server.configuration.hostname = "0.0.0.0"
    app.http.server.configuration.port = 8080
    try routes(app)
}

🎨 스크린샷

iPhone SE(2세대) iPhone 14 iPhone 16 Pro Max
서버라 음슴미다.. 스샷 스샷

🚀 테스트 방법

테스트 코드가 없어요 흑흑

@youn9k youn9k added the ✨ feat 새로운 기능 추가 label Nov 7, 2024
@youn9k youn9k self-assigned this Nov 7, 2024
@youn9k youn9k linked an issue Nov 7, 2024 that may be closed by this pull request
서버 스펙 변경 Node.js -> Vapor #5
Closed
2 tasks
0Hooni
0Hooni reviewed Nov 7, 2024
View reviewed changes
PhotoGetherServer/PhotoGetherServer/Sources/App/routes.swift Outdated
Comment on lines 7 to 8
app.webSocket("signaling") { req, ws in
connections.append(ws)
Copy link
Collaborator

@0Hooni 0Hooni Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

req, ws같은 축약으로 설정해준 부분이 보이는데 직관적인 네이밍으로 해주시면 좋아보여요

Copy link
Member Author

@youn9k youn9k Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9fe8a8f

수정했습니다!

0Hooni
0Hooni approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@0Hooni 0Hooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTVOLEDLGTM 👍

Kiyoung-Kim-57
Kiyoung-Kim-57 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@Kiyoung-Kim-57 Kiyoung-Kim-57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 읽었습니다😀

PhotoGetherServer/PhotoGetherServer/Sources/App/routes.swift Outdated

// 클라이언트가 연결을 종료할 때 호출
ws.onClose.whenComplete { _ in
connections.removeAll { $0 === ws }
Copy link
Member

@Kiyoung-Kim-57 Kiyoung-Kim-57 Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

==로 비교하면 안되는지 궁금합니다!

Copy link
Member Author

@youn9k youn9k Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

배열안에 담긴 타입이 레퍼런스타입이라 ===으로 비교해주었습니다!

@youn9k youn9k merged commit 7a1f875 into develop Nov 7, 2024
@youn9k youn9k deleted the feature/#5-migrate-server branch November 9, 2024 01:45
@youn9k youn9k linked an issue Nov 9, 2024 that may be closed by this pull request
시그널링 서버 구현 #7
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0Hooni 0Hooni 0Hooni approved these changes

@Kiyoung-Kim-57 Kiyoung-Kim-57 Kiyoung-Kim-57 approved these changes

@hsw1920 hsw1920 Awaiting requested review from hsw1920

Assignees

@youn9k youn9k

Labels

✨ feat 새로운 기능 추가

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

시그널링 서버 구현 서버 스펙 변경 Node.js -> Vapor

4 participants

@youn9k @0Hooni @Kiyoung-Kim-57