-
Notifications
You must be signed in to change notification settings - Fork 2
[Feat/#44] PhotoRoom 화면을 구현합니다 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 필터 아이콘 추가 - 카메라 전환 아이콘 추가 - PTGImage에 해당 아이콘들 case 추가
- 카메라 버튼 구현 - 카메라 버튼 터치 시 색상 변경 구현 - Constants의 버튼 사이즈는 카메라 버튼 객체 생성하는 위치에서 사용해야하기에 internal로 접근 제어자 설정
- PhotoRoom Host BottomView 구현 - 상수 부분 이후 따로 extension에 정적 변수로 관리 예정
- 상수 추후 extension에서 정적 변수로 관리 예정
- 안쓰는 케이스인줄 알고 지웠던 temp1, temp2 case 복구
- 기존 카메라 버튼에 Bool 값을 추가해 호스트와 게스트에 따라 모양이 바뀌도록 했습니다
- isHost 변수를 통해 호스트 게스트 구분 - 둘이 동시에 사용할 수 있으니 파일 이름 변경
- 화질구린 이미지 svg로 변경했습니다.
- 카메라 누르면 input이 전달되어 뷰 모델에 input 전달 - timer output이 뷰로 전달 - 타이머가 끝나면 뷰모델에서 timerCompleted output 전달 - 그 외 상수 extension으로 따로 분리
- init에 true를 넣으면 호스트, false는 게스트로 UI 테스트 가능
Closed
6 tasks
youn9k
reviewed
Nov 19, 2024
...nLayer/PhotoRoomFeature/PhotoRoomFeature/Source/ViewController/PhotoRoomViewController.swift
Show resolved
Hide resolved
youn9k
reviewed
Nov 19, 2024
...nLayer/PhotoRoomFeature/PhotoRoomFeature/Source/ViewController/PhotoRoomViewController.swift
Outdated
Show resolved
Hide resolved
youn9k
reviewed
Nov 19, 2024
...nLayer/PhotoRoomFeature/PhotoRoomFeature/Source/ViewController/PhotoRoomViewController.swift
Outdated
Show resolved
Hide resolved
hsw1920
approved these changes
Nov 19, 2024
Collaborator
hsw1920
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코멘트 남겼습니다 고생하셨어요!
...er/PresentationLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/PhotoRoomBottomView.swift
Outdated
Show resolved
Hide resolved
...resentationLayer/PhotoRoomFeature/PhotoRoomFeature/Source/ViewModel/PhotoRoomViewModel.swift
Outdated
Show resolved
Hide resolved
...nLayer/PhotoRoomFeature/PhotoRoomFeature/Source/ViewController/PhotoRoomViewController.swift
Outdated
Show resolved
Hide resolved
...nLayer/PhotoRoomFeature/PhotoRoomFeature/Source/ViewController/PhotoRoomViewController.swift
Show resolved
Hide resolved
0Hooni
approved these changes
Nov 19, 2024
Collaborator
0Hooni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
수고 많으셨습니다!!
PhotoGether/PresentationLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/CameraButton.swift
Show resolved
Hide resolved
PhotoGether/PresentationLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/CameraButton.swift
Show resolved
Hide resolved
PhotoGether/PresentationLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/CameraButton.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
📃 작업 내역
✅ 리뷰 노트
🎨 스크린샷
🚀 테스트 방법