[FEAT/#1] 참가자 화면 컬렉션 뷰를 구현합니다. #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Closed
2 tasks
0Hooni
approved these changes
Nov 14, 2024
Collaborator
0Hooni
left a comment
0Hooni
left a comment
There was a problem hiding this comment.
코드가 읽기 너무 좋게 잘 짜신것 같아요!!
덕분에 리뷰하기 수월했습니다 ㅎㅎ
수고 많으셨습니다! 👍
Collaborator
There was a problem hiding this comment.
자간 설정하는건 처음보는데 이렇게 하는군요!
저희도 라벨 쓰는곳이 있었는데 디벨롭에 들어오면 적용해봐야겠네요
...esentationLayer/PhotoRoomFeature/PhotoRoomFeature/Source/Model/ParticipantsSectionItem.swift
Outdated
Show resolved
Hide resolved
...tionLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/ParticipantsCollectionViewCell.swift
Show resolved
Hide resolved
...oomFeature/PhotoRoomFeature/Source/ViewController/ParticipantsCollectionViewController.swift
Show resolved
Hide resolved
hsw1920
approved these changes
Nov 15, 2024
...tionLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/ParticipantsCollectionViewCell.swift
Show resolved
Hide resolved
...oomFeature/PhotoRoomFeature/Source/ViewController/ParticipantsCollectionViewController.swift
Show resolved
Hide resolved
hsw1920
reviewed
Nov 15, 2024
...tionLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/ParticipantsCollectionViewCell.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
참가자 대기 화면 (WaitingRoomFeature) 과 사진 촬영 화면 (PhotoRoomFeature) 에서 공통으로 사용되는 참여자 화면을 구현해야 했습니다.
📃 작업 내역
추가된 타입과 메소드는 아래와 같습니다.
ParticipantsCollectionViewController: 2x2 형태의 참가자 화면을 컬렉션뷰로 구현합니다.ParticipantsCollectionViewCell: 참가자 컬렉션 뷰에서 사용되는 셀로 참가자 한명의 화면을 나타냅니다.ParticipantsSectionItem: DiffableDataSource에 사용되는 모델입니다.ParticipantsCollectionViewDataSource: DiffableDataSource로 추후 참가자 화면 순서를 변경할 때 애니메이션을 적용하기 위해 사용합니다.setKern(): UILabel Extension 메소드로 자간을 설정해주는 메소드입니다.✅ 리뷰 노트
상대방의 화면은 ConnectionClient 에 UIView 프로퍼티로 가지고 있습니다.
컬렉션뷰 셀에 들어갈 UIView 정보를 SectionItem 구조체에서 들고 있고, 셀에 UIView를 주입해주면 셀이 재사용될 때 메모리 누수와 같은 문제가 발생할 수 있어
videoID: Int정보만 들고 있도록 했습니다.