-
Notifications
You must be signed in to change notification settings - Fork 2
[FEAT/#22] CI를 진행합니다. #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Kiyoung-Kim-57
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
와 우리도 CI😀 고생하셨습니다
| override func viewDidLoad() { | ||
| super.viewDidLoad() | ||
| view.backgroundColor = .red | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
원래대로 돌려주실거죠?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 들켰다
hsw1920
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!!
0Hooni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI 만들어주셨군요!!
감사합니다. 수고 많으셨어요👍
🤔 배경
main과 develop 브랜치는 많은 작업 브랜치의 베이스가 되는 중요한 브랜치입니다.
그래서 main과 develop 브랜치에 PR이 머지되기 전 / 머지된 후 빌드가 정상적으로 되는지 확인하기 위한 작업을 자동화하기 위해 Github Action을 활용해 빌드를 자동화했습니다.
📃 작업 내역
✅ 리뷰 노트
빌드가 되는지를 테스트하는건데 DerivedData를 캐싱해도 되는지 의문입니다 🤔
DerivedData를 통해 증분 빌드를 하게 될텐데, 완전히 깨끗한 환경에서 빌드가 되는지를 테스트해야하는지 고민이네요?!
우선 SPM Dependency와 DerivedData를 캐싱하지 않았을 때와 캐싱 했을 때 CI 속도는 각각 8분 vs 1분 50초로 어마어마한 차이가 났습니다..
무결한 환경에서의 빌드 테스트 vs 무결성은 살짝 떨어지지만 빠른 빌드
뭐가 좋을까요?
🎨 스크린샷