[FEAT/#143] 몬생긴 이모지를 교체했습니다 #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- URL에 이모지 넣으면 된다는데, 안되는 몇몇이 존재함 - 그래서 hexCode로 다운로드 하게 변경
Closed
1 task
hsw1920
approved these changes
Dec 1, 2024
Collaborator
There was a problem hiding this comment.
.init을 사용하고 계신대요, 해당 경우에 struct의 경우에는 정적 디스패치를 보장한다고 알고 있어서 성능상 불리함이 없다고 알고 있는데, 그래도 지양해야된다고 영규님이 말씀해주셨는데 잘 이해가 안됩니당.. @youn9k 헬프
Member
There was a problem hiding this comment.
Static Disptach로 동작해 런타임 성능에는 문제가 없지만, 컴파일 단계에서 타입 추론이 필요해 컴파일 시간이 증가하는 걸로 알고 있어요. 그래서 지양하는게 좋아보입니다ㅎㅎ
| var baseURL: URL { URL(string: "https://api.api-ninjas.com")! } | ||
| var path: String { "v1/emoji" } | ||
| let group: EmojiGroup | ||
|
|
youn9k
approved these changes
Dec 2, 2024
Member
youn9k
left a comment
youn9k
left a comment
There was a problem hiding this comment.
이모지 API가 변경되었군요! 예쁜게 많아서 좋네요ㅎㅎ
Kiyoung-Kim-57
approved these changes
Dec 2, 2024
Member
Kiyoung-Kim-57
left a comment
Kiyoung-Kim-57
left a comment
There was a problem hiding this comment.
와 역시!! 좋은 이미지 좋슴다!!😄😄😄
Member
|
하지만 Lint는 고쳐주세요~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
📃 작업 내역
✅ 리뷰 노트
🎨 스크린샷
🚀 테스트 방법