[FEAT/#151] 참가자들의 화면 순서를 동기화 합니다. #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
Co-Authored-By: Kiyoung <121777185+Kiyoung-Kim-57@users.noreply.github.com>
youn9k
requested review from
0Hooni,
Kiyoung-Kim-57 and
hsw1920
and removed request for
Kiyoung-Kim-57 and
hsw1920
hsw1920
approved these changes
Dec 1, 2024
PhotoGether/DataLayer/PhotoGetherData/PhotoGetherData/ConnectionRepositoryImpl.swift
Show resolved
Hide resolved
...er/PhotoGetherDomain/PhotoGetherDomain/UseCaseImpl/DidEnterNewUserPublisherUseCaseImpl.swift
Show resolved
Hide resolved
...mainLayer/PhotoGetherDomain/PhotoGetherDomainInterface/Repository/ConnectionRepository.swift
Show resolved
Hide resolved
.../WaitingRoomFeature/WaitingRoomFeature/Source/ViewController/WaitingRoomViewController.swift
Show resolved
Hide resolved
...ationLayer/WaitingRoomFeature/WaitingRoomFeature/Source/ViewModel/WaitingRoomViewModel.swift
Show resolved
Hide resolved
hsw1920
reviewed
Dec 1, 2024
...ationLayer/WaitingRoomFeature/WaitingRoomFeature/Source/ViewModel/WaitingRoomViewModel.swift
Outdated
Show resolved
Hide resolved
불필요한 cancel 메소드 제거
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
서로 다른 순서라면 포즈를 취할 때 어색하기 때문에 순서를 맞춰주는 것이 중요했습니다.
📃 작업 내역
✅ 리뷰 노트
리뷰 해줘~~
🎨 스크린샷
🚀 테스트 방법