Skip to content

Conversation

@youn9k
Copy link
Member

@youn9k youn9k commented Nov 26, 2024

🤔 배경

에러나 사용자 액션에 대한 반응이 없으면 사용자 경험에 악영향을 끼치기 때문에, 간단하게 토스트 메시지라도 띄울 수 있도록 했습니다.

📃 작업 내역

  • BaseFeature가 DesignSystem을 의존하도록 합니다.
  • BaseFeature에 UIViewController Extension 메소드로 showToast(message:, duration:) 을 추가합니다.

✅ 리뷰 노트

🎨 스크린샷

최대 Width 는 뷰 프레임의 0.7배로 설정

🚀 테스트 방법

BaseFeature를 import한 후, ViewController 내에서 showToast(message: ) 메소드를 호출하면 됩니다.

@youn9k youn9k added the ✨ feat 새로운 기능 추가 label Nov 26, 2024
@youn9k youn9k self-assigned this Nov 26, 2024
@youn9k youn9k linked an issue Nov 26, 2024 that may be closed by this pull request
import UIKit
import DesignSystem

public extension UIViewController {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseViewController에 확장하는 건 어떨까요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BaseViewController가 UIViewController를 상속하고 있어서 사용가능해요!

Copy link
Collaborator

@hsw1920 hsw1920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Copy link
Collaborator

@0Hooni 0Hooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

간지 뒤지는 토스트 👍

수고많으셨습니다!!

Copy link
Member

@Kiyoung-Kim-57 Kiyoung-Kim-57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@youn9k youn9k merged commit 9b541b4 into develop Nov 27, 2024
1 check passed
@youn9k youn9k deleted the feat/107-show-toast branch November 27, 2024 01:22
@klmhyeonwoo
Copy link

천재다,, 천재다!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feat 새로운 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

토스트 메시지를 띄울 수 있도록 합니다.

6 participants