[FEAT/#105] 비동기 이미지 설정 메소드를 추가합니다. #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
0Hooni
approved these changes
Nov 26, 2024
Collaborator
0Hooni
left a comment
0Hooni
left a comment
There was a problem hiding this comment.
LGTM 💯
이미지 세팅할 때 잘 쓰일것 같아요 👍
수고하셨습니다!
PhotoGether/PresentationLayer/BaseFeature/BaseFeature/Extension/UIImageView+SetAsyncImage.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
이미지 url을 통해 비동기로 설정하는 메소드를 각자 만들어 사용하고 있어 하나의 메소드로 통일하고자 했습니다.
📃 작업 내역
BaseFeature에 UIImageView Extension메소드를 추가했습니다.
✅ 리뷰 노트
다양한 컨텍스트에서 사용할 수 있도록
DispatchQueue를 사용하는 메소드와 async/await를 사용하는 메소드로 오버로딩 해두었습니다!