[FE] Refactor : 타입스크립트 코드 수정, 이미지 크기 재조정, Data Fetch 로직 수정 #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- type aliases -> interface로 변경 (일관성을 위해) - getServerSideProps는 next에서 제공하는 GetServerSideProps 타입으로 타입선언을 해줌으로써 타입스크립트 사용 의의를 높임
- CDN이미지 사이즈를 재조정하고, 사용하지 않는 이미지 파일 제거 - StaticProps, Staticpaths를 사용하여 동적 라우팅하는 [id] 파일의 데이터를 빌드시점에서 불러오도록 로직 수정정 (변화가 없는 데이터이며, SEO와 관계되는 데이터이므로)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
(변화가 없는 데이터이며, SEO와 관계되는 데이터이므로)