Gco/fix double exit processing #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, each additional level of state machine multiply by 3 the number of times an anonymous event is processed by a sub state machine.
Add test on defer in sub state.
Fix process_defer_events return value. Loop on process_defer_events until stability is reached. Remove process_defer_events after process_queued_events since it was used as stopgag when process_defer_events return value was erroneous.
Stop anonymous events from being propagated inside sub state machine. Anonymous events are all triggered by process_event. Without this, each additional layer multiply by 3 the number of times an anonymous event is processed by the sub state machine.
The removed events are unexpected, those unexpected events are no longer processed in substate machine that cannot process them due to changes in previous commit.
|
This MR fix the bug when rebased after my other PR https://github.com/GuiCodron/sml/tree/gco/fix_recursive_processing |
non trivial events seems to be incorrectly triggered, add tests to show that.
GuiCodron
force-pushed
the
gco/fix-double-exit-processing
branch
from
ab6d538 to
2f1cec4
Compare
exit events where sometimes called 2 times due to the fact that they always returned false. This was always triggering process_internal_generic_event in include/boost/sml/back/state_machine.hpp line 190. Change implementation to have a behavior similar to the on_entry events but with reversed logic, bottom to top instead of top to bottom
GuiCodron
force-pushed
the
gco/fix-double-exit-processing
branch
from
2f1cec4 to
792cee6
Compare
|
Nice @GuiCodron 👍 Thank you for tests and generation of sml.hpp 👍 |
|
@GuiCodron @krzysztof-jusiak I've also faced this issue and it works as expected now, Thank You! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Solution:
Resolve the problem by matching on_exit handling inside transitions with how on_entry is handled.
Issue: #369
Reviewers:
@krzysztof-jusiak