Subclass Parsing Issue

[mcdonop]

I just started using boon and it is FAST! However, I think I found an issue with subclassing. Parsing is not detecting the "class" attribute. I saw the Person/Pet/Dog example, and verified that example does work. I am not entirely sure why my case does not work but I am thinking it is because there are no abstract, interfaces defined.

I believe I am using boon correctly in my test case. If you could please look at this issue, I would appreciated it. And if you agree, is the proposed fix correct?

Please see complete test project attached. I am using boon-0.30.jar.

I was able to get the test case attached to work by changing the code in

org.boon.core.reflection.MapperSimple

    private <T> void fromValueMapHandleValueCase(T newInstance, FieldAccess field, Value value) {

            case INSTANCE:
                switch (value.type()) {
                    case MAP:
                        // ********************************************
                        // Begin fix
                        // ********************************************
                        final Map<String, Value> valueMap = (Map<String, Value>) objValue;
                        final Value aClass = valueMap.get("class");
                        if (aClass != null) {
                            clazz = Reflection.loadClass(aClass.stringValue());
                        }
                        // ********************************************
                        // End fix
                        // ********************************************
                        objValue = fromValueMap( ( Map<String, Value> ) objValue, clazz );
                        break;
                    case LIST:
                        objValue = fromList((List<Object>) objValue, clazz);
                        break;


                }
                field.setValue(newInstance, objValue);

                break;

I think a similar change is needed to MapperComplex.

@Test
    public void test() {

        RequestContext requestContext = new RequestContext();
        requestContext.setMessageID("123");

        DoThisApplicationRequest doThisApplicationRequest = new DoThisApplicationRequest();
        doThisApplicationRequest.setSomeValue("hello");

        ApplicationRequest applicationRequest = new ApplicationRequest();
        applicationRequest.setRequestContext(requestContext);
        applicationRequest.setServiceRequest(doThisApplicationRequest);
        applicationRequest.setVersion("1.0.0");

        final JsonSerializer serializer = new JsonSerializerFactory ().useAnnotations().create ();
        JsonParserAndMapper jsonParserAndMapper = new JsonParserFactory().setLazyChop(true).create();
        ApplicationRequest applicationRequestCopy = jsonParserAndMapper.parse(ApplicationRequest.class, serializer.serialize(applicationRequest).toCharArray());

        assertTrue(applicationRequest.getServiceRequest() instanceof DoThisApplicationRequest);
        assertTrue(applicationRequestCopy.getServiceRequest() instanceof DoThisApplicationRequest);

    }

[RichardHightower]

Ok... well if you have a fix... Then you should send a pull request. :)

[mcdonop]

ok.. will do... new to this.. let me figure out how to do the pull request and will deliver... thanks

[RichardHightower]

i lieu of a patch. can you send code to reproduce the problem.

[mcdonop]

Please see attached…

test case is in src/boon/test/Subclass.java

On Jan 5, 2015, at 8:20 PM, Richard Hightower notifications@github.com wrote:

i lieu of a patch. can you send code to reproduce the problem.

—
Reply to this email directly or view it on GitHub #281 (comment).

[RichardHightower]

Your file did not attach to this issue. Do you want to make just cut/paste it in the comment block.. If you ``` around your code.. It turns it into a code listing.

[mcdonop]

Model

package boon.model;

public class ApplicationRequest {

    protected RequestContext requestContext;
    protected ServiceRequest serviceRequest;
    protected String version;

    public RequestContext getRequestContext() {return requestContext;}
    public void setRequestContext(RequestContext requestContext) {this.requestContext = requestContext;}
    public ServiceRequest getServiceRequest() {return serviceRequest;}
    public void setServiceRequest(ServiceRequest serviceRequest) {this.serviceRequest = serviceRequest;}
    public String getVersion() {return version;}
    public void setVersion(String version) {this.version = version;}

}

package boon.model;

public class DoThisApplicationRequest extends ServiceRequest {

    protected String someValue;

    public String getSomeValue() {return someValue;}
    public void setSomeValue(String someValue) {this.someValue = someValue;}


}

package boon.model;

public class RequestContext {

    protected String messageID;

    public String getMessageID() {return messageID;}
    public void setMessageID(String messageID) {this.messageID = messageID;}

}

package boon.model;

public class ServiceRequest {

    protected String version;

    public String getVersion() {return version;}
    public void setVersion(String version) {this.version = version;}

}

Test Code

package boon.test;

import static org.junit.Assert.assertTrue;

import org.boon.json.JsonParserAndMapper;
import org.boon.json.JsonParserFactory;
import org.boon.json.JsonSerializer;
import org.boon.json.JsonSerializerFactory;
import org.junit.Test;

import boon.model.ApplicationRequest;
import boon.model.DoThisApplicationRequest;
import boon.model.RequestContext;

public class Subclass {

    @Test
    public void test() {

        RequestContext requestContext = new RequestContext();
        requestContext.setMessageID("123");

        DoThisApplicationRequest doThisApplicationRequest = new DoThisApplicationRequest();
        doThisApplicationRequest.setSomeValue("hello");

        ApplicationRequest applicationRequest = new ApplicationRequest();
        applicationRequest.setRequestContext(requestContext);
        applicationRequest.setServiceRequest(doThisApplicationRequest);
        applicationRequest.setVersion("1.0.0");

        final JsonSerializer serializer = new JsonSerializerFactory ().useAnnotations().create ();
        JsonParserAndMapper jsonParserAndMapper = new JsonParserFactory().setLazyChop(true).create();
        ApplicationRequest applicationRequestCopy = jsonParserAndMapper.parse(ApplicationRequest.class, serializer.serialize(applicationRequest).toCharArray());

        assertTrue(applicationRequest.getServiceRequest() instanceof DoThisApplicationRequest);
        assertTrue(applicationRequestCopy.getServiceRequest() instanceof DoThisApplicationRequest);

    }

}

[RichardHightower]

You have been waiting for this for a while. I will take a look today sometime.
Thanks for posting the listing.

[dsmogor]

Hello, I stumbled upon the same issue and created a PR on my own.
Could I kindly ask for a review.