Skip to content

Conversation

@michael-emmi
Copy link
Collaborator

This PR aims to automate the publishing of dotnet global tools for Corral.

@michael-emmi
Copy link
Collaborator Author

@bkragl @zvonimir @akashlal thoughts about this one?

(Basically this replicates the versioning and releasing we have built for Boogie.)

Question for @akashlal: since Corral is currently unversioned, what version should we start at?

  • fresh at v1.0.0
  • matching Boogie at v2.4.4
  • something different altogether?

@zvonimir
Copy link
Collaborator

To me it makes sense that this should be done for all tools that depend on Boogie, and so it is awesome that you are doing this. I can't really comment on the details of the implementation.

About the version number, I guess I would start with v1.0.0. I don't see a good reason to start with the current version of Boogie.

@michael-emmi
Copy link
Collaborator Author

About the version number, I guess I would start with v1.0.0. I don't see a good reason to start with the current version of Boogie.

Ok, then let’s make sure to include #major in the first line of the merge commit message — that should generate the tag v1.0.0.

Copy link
Member

@bkragl bkragl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can compile on my machine. Perhaps the new build instructions should be added to the readme file. In particular this step I found in the Travis configuration:

# Attach HEADs in submodules to appease GitVersion
git submodule foreach 'git branch -d master && git checkout -b master'

@michael-emmi
Copy link
Collaborator Author

Perhaps the new build instructions should be added to the readme file.

Good idea, I’ll do that.

@michael-emmi
Copy link
Collaborator Author

NOTE: be sure to include #major in the first line of the merge commit when merging this.

@michael-emmi
Copy link
Collaborator Author

@akashlal any objections to this PR?

@michael-emmi michael-emmi merged commit 2d33864 into boogie-org:master Dec 31, 2019
@michael-emmi
Copy link
Collaborator Author

Oh crap I merged by accident…

@michael-emmi
Copy link
Collaborator Author

Confirming with @akashlal this is OK; otherwise we can always create a revert PR.

@akashlal
Copy link
Contributor

akashlal commented Jan 2, 2020

Looks good, thanks!

michael-emmi added a commit that referenced this pull request Jan 2, 2020
Restoring TotalUserTime increment removed by #106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants