-
Notifications
You must be signed in to change notification settings - Fork 31
Versioning and global tool deployment #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@bkragl @zvonimir @akashlal thoughts about this one? (Basically this replicates the versioning and releasing we have built for Boogie.) Question for @akashlal: since Corral is currently unversioned, what version should we start at?
|
|
To me it makes sense that this should be done for all tools that depend on Boogie, and so it is awesome that you are doing this. I can't really comment on the details of the implementation. About the version number, I guess I would start with v1.0.0. I don't see a good reason to start with the current version of Boogie. |
Ok, then let’s make sure to include #major in the first line of the merge commit message — that should generate the tag |
bkragl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I can compile on my machine. Perhaps the new build instructions should be added to the readme file. In particular this step I found in the Travis configuration:
# Attach HEADs in submodules to appease GitVersion
git submodule foreach 'git branch -d master && git checkout -b master'
Good idea, I’ll do that. |
|
NOTE: be sure to include |
|
@akashlal any objections to this PR? |
|
Oh crap I merged by accident… |
|
Confirming with @akashlal this is OK; otherwise we can always create a revert PR. |
|
Looks good, thanks! |
Restoring TotalUserTime increment removed by #106.
This PR aims to automate the publishing of dotnet global tools for Corral.