-
Notifications
You must be signed in to change notification settings - Fork 149
Fixed console multiline behavior #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed console multiline behavior #141
Conversation
Build is actually failing because 2 test are failing, they seems not related with the PR because i've noticed that also master, is failing for the same reason. |
This looks very nice, and it's something booish has sorely needed for a long time. I can't test it now, but I'll check this when I get home this evening and if it works, I'll merge it. 😄 |
This works really well, except that if you go beyond one line, the Can you look into this? If those two keys were fixed, this would be ready to merge. :) |
Ok i should have fixed Home & End key behaviors, it's still failing the build for the aforementioned two tests but it works on my machine, I did an extra-commit to clean csproj files that were changed (probably by my VS), now the pull request is correctly reporting changing just 1 file (InteractiveInterpreterConsole.boo). Make me know if it works as intended... |
These changes look good. I've noticed one other minor problem, but it's small enough that it's not worth delaying the merge for. If I write a statement and press Can you come up with a PR to fix this? Merging and closing this PR now, because it doesn't seem like that's a scenario that is likely to happen very often. |
Fixed the annoying behavior of booish.exe when a command spills on multiple line, i've tested it with delete, history, autocompletion, indent, key arrows and insert.