Fix various issues with Extensions.csproj handling and add unit testing for it
#2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting for it * Fix whitespace being stripped during automatic updates * Fix fresh `Extensions.csproj` always being written with CRLF newlines * Fix `ScriptExtensionsProjectMetadata` not actually being immutable as intended * Fix adding redundant `ItemGroup` when all `PackageReference`s were removed but the group wasn't * Added automatic exposing of assembly internals to the relevant test assembly * Upgraded to C# 12 to get raw strings (our `global.json` already requires the .NET 8 SDK anyway) Fixes bonsai-rx#2055
PathogenDavid
commented
Mar 11, 2025
| CollectionAssert.AreEquivalent((string[])["FakePackageA", "FakePackageB"], metadata.GetPackageReferences().ToArray()); | ||
|
|
||
| // Package was not updated | ||
| //TODO: This is how the implementation is written, but is this behavior correct? |
There was a problem hiding this comment.
This test covers the behavior provided by this check:
It's been like this since 2018 when automatic Extensions.csproj updating was introduced.
Is this behavior actually a good idea? It seems to me like the Extensions.csproj should always match the Bonsai environment since the two not matching only causes confusion.
|
Do we want to special-case saving to automatically re-add newlines if the original project had none in order to undo the damage caused by #2055 ? Should be as simple as skipping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was initially focused on #2055, which was caused by an oversight done when refactoring the several redundant XML parsing entrypoints during #1753 (Prior to the refactor, all of them stripped whitespace except for the one that loaded the project for adding package references. That exception was lost in the refactor.)
While I was at it I wrote a suite of unit tests related to the handling of
Extensions.csprojand fixed some other issues I found along the way.Extensions.csprojalways being written with CRLF newlinesScriptExtensionsProjectMetadatanot actually being immutable as intendedItemGroupwhen allPackageReferences were removed but the group wasn'tglobal.jsonalready requires the .NET 8 SDK anyway)Fixes #2055