Skip to content

Conversation

@Wheest
Copy link

@Wheest Wheest commented May 6, 2024

New releases use the autogen.sh script in the same way as pulling from the git repo does.

I've updated the README to reflect that.

I also had an issue similar to #68, which was because I was missing the pkg-config dependency. This is now noted in the README

Wheest added 2 commits May 6, 2024 15:35
New releases use the autogen.sh script, README is updated to reflect that
@bondhugula bondhugula self-requested a review May 12, 2024 15:42
README.md Outdated
$ PLUTO_VERSION=0.12.0
$ tar zxvf pluto-${PLUTO_VERSION}.tar.gz
$ cd pluto-${PLUTO_VERSION}/
$ ./autogen.sh
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A release package shouldn't require a user to generate/regenerate the build config. The user shouldn't even ideally need to have autoconf/automake to build pluto from a release package (as opposed to the git repo). Please drop ./autogen.sh - not including that step was intentional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I pull the latest release (0.12.0), then the build config (a configure file that I can run with ./configure) isn't present. This is why I added the ./autogen.sh step.

wget https://github.com/bondhugula/pluto/releases/download/0.12.0/pluto-0.12.0.tar.gz
tar xfvz pluto-0.12.0.tar.gz 
cd pluto-0.12.0/

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release was meant to have a configure file - thank you for pointing this out. I'll update the release to include it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the release - the new release 0.13.0 has the configure file: https://github.com/bondhugula/pluto/releases/tag/0.13.0

Copy link
Owner

@bondhugula bondhugula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit looks good. The cleanup part of the first commit also looks good - thanks.

@Wheest
Copy link
Author

Wheest commented Mar 17, 2025

Cheers, and thanks for updating the new release!

@bondhugula
Copy link
Owner

If you want to retain just the second commit, we can merge it in. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants