-
Notifications
You must be signed in to change notification settings - Fork 75
Update README.md to reflect autogen requirement #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
New releases use the autogen.sh script, README is updated to reflect that
README.md
Outdated
| $ PLUTO_VERSION=0.12.0 | ||
| $ tar zxvf pluto-${PLUTO_VERSION}.tar.gz | ||
| $ cd pluto-${PLUTO_VERSION}/ | ||
| $ ./autogen.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A release package shouldn't require a user to generate/regenerate the build config. The user shouldn't even ideally need to have autoconf/automake to build pluto from a release package (as opposed to the git repo). Please drop ./autogen.sh - not including that step was intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I pull the latest release (0.12.0), then the build config (a configure file that I can run with ./configure) isn't present. This is why I added the ./autogen.sh step.
wget https://github.com/bondhugula/pluto/releases/download/0.12.0/pluto-0.12.0.tar.gz
tar xfvz pluto-0.12.0.tar.gz
cd pluto-0.12.0/There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release was meant to have a configure file - thank you for pointing this out. I'll update the release to include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the release - the new release 0.13.0 has the configure file: https://github.com/bondhugula/pluto/releases/tag/0.13.0
bondhugula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second commit looks good. The cleanup part of the first commit also looks good - thanks.
|
Cheers, and thanks for updating the new release! |
|
If you want to retain just the second commit, we can merge it in. Thanks. |
New releases use the autogen.sh script in the same way as pulling from the git repo does.
I've updated the README to reflect that.
I also had an issue similar to #68, which was because I was missing the
pkg-configdependency. This is now noted in the README