Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PositonFor to ignore //line directives #140

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Use PositonFor to ignore //line directives #140

merged 1 commit into from
Nov 28, 2023

Conversation

bombsimon
Copy link
Owner

This is especially important in analyzer.go where we need to get the filename of the actual file so we can skip non Go files. This is used to skip the cached generated test files that are passed from the GOCACHE

@bombsimon
Use PositonFor to ignore //line directives
5e00d04 
This is especially important in `analyzer.go` where we need to get the
filename of the actual file so we can skip non Go files. This is used to
skip the cached generated test files that are passed from the `GOCACHE`
@coveralls
Copy link

Coverage Status

coverage: 93.637%. remained the same
when pulling 5e00d04 on position-for
into edc9d8c on master.

@bombsimon bombsimon merged commit 956337b into master Nov 28, 2023
6 checks passed
@bombsimon bombsimon deleted the position-for branch November 28, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bombsimon @coveralls