feat(autocomplete): add wrapping and window limits #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two things to the autocomplete prompt: 1. Wrapping (in that options can now wrap across multiple lines) 2. Automatically shrinking the max items displayed if they don't fit on the screen The limit options helper has become quite a bit more complicated to handle the latter 😬 but that's _probably_ ok.
🦋 Changeset detectedLatest commit: aa80be9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@example/basic • @example/changesets commit: |
dreyfus92
reviewed
Aug 29, 2025
Collaborator
Author
|
ill add the tests before we merge 👍 thanks for reviewing 🙏 |
Collaborator
Author
|
@dreyfus92 i've added tests for autocomplete wrapping and limit-options itself |
43081j
commented
Sep 15, 2025
| return { lineCount, removals }; | ||
| }; | ||
|
|
||
| export const limitOptions = <TOption>(params: LimitOptionsParams<TOption>): string[] => { |
Collaborator
Author
There was a problem hiding this comment.
this logic is a bit bonkers so if you want it explaining, feel free to catch me on discord
dreyfus92
reviewed
Sep 16, 2025
Member
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
just a nit, dunno if it TS would yell 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two things to the autocomplete prompt:
The limit options helper has become quite a bit more complicated to handle the latter 😬 but that's probably ok.
Fixes #318