remove lodash dependencies (fixes build too) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+6
to
+8
| public static isNullOrUndefined(o: any): boolean { | ||
| return o == null | ||
| } |
There was a problem hiding this comment.
should this be tested? (Ergo does it work with undefined)
Comment on lines
+24
to
+26
| public static deepCopy(value: object): object { | ||
| return JSON.parse(JSON.stringify(value)) | ||
| } |
There was a problem hiding this comment.
Is this the best/fastest of doing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The @types/lodash dependency was causing issues in the build. I didn't see the benefit of keeping the external dependency in for the few functions used.
Other changes caused by autoformatting. I guess my editor used the tslint config that is already included in the project.
Also added the yarn.lock file to lock the dependency versions in the repo.