Skip to content

Correct onScroll throttling #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zzorba
Copy link

@zzorba zzorba commented Dec 2, 2021

Problem I observed is detailed here: #466

This PR corrects the logic in two ways:

  1. Changes the throttle to compare numbers in correct direction, before the if condition was always false.
  2. Start utilizing the updateTimeInterval prop which was previously being ignored throughout the code.

Wasn't totally sure about number 2, but my read was this was the logical place to control that logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant