Need to set LoadbalancerIP in Service specification. Patch to copy all specs over from Values files. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to copy over loadBalancerIP to grab a predefined static ip
komasoftware
changed the title
|
Thank you for the commit. Could you please update Thanks, |
|
Sure, I will do that. Can I make my forked repo easily function as helm repo by publishing the gh-pages so I can test this out against my fork ? |
|
|
Everything cleaned up, added a test and updated README. |
|
Last commit fixes the merge conflict in the README |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to copy over loadBalancerIP to grab a predefined static ip.
This patch copies over all
specsettings predefined in the values file.