Merges #201 with current master, adds support for development on Windows #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antifuchs
reviewed
Jun 10, 2024
Comment on lines
+71
to
+79
| # Due to #![deny(warnings)] you can't compile the crate without these lints disabled. | ||
| # These are simple to resolve lints, it's up to Andreas Fuchs if they should be resolved. | ||
| # | ||
| # -- koshell | ||
| [lints.clippy] | ||
| default_constructed_unit_structs = "allow" | ||
| single_char_pattern = "allow" | ||
| len_zero = "allow" | ||
| clone_on_copy = "allow" |
There was a problem hiding this comment.
Hm, I'd prefer to resolve warning-scale lints than to ignore them (unless resolving them is extremely noisy or leads to API clutter). Where do you see these trigger? I tried running clippy from stable rust 1.79.0, and it doesn't warn (with the clippy fixes from latest HEAD).
There was a problem hiding this comment.
@antifuchs Looked over the master branch to confirm if it still produced clippy warnings.
#235 is a list of the warnings it spits out for me. I went through and tagged where in the code each warning originated instead of in the Cargo.toml to make it easier to review.
I left some suggestions in the pull request to resolve the lints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated #201 to allow for easy merging.
While I was there I also fixed up the tests to allow them to run on windows.
All current tests pass.
I'm happy to fix up any other issues blocking this from merging.