Skip to content

Commit

Permalink
Merge pull request rails#31671 from larskanis/pg-1.0
Browse files Browse the repository at this point in the history
PostgreSQL: Allow pg-1.0 gem to be used with ActiveRecord
  • Loading branch information
rafaelfranca committed Jan 11, 2018
1 parent 4cc2ea7 commit a9c06f6
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ group :job do
gem "sidekiq", require: false
gem "sucker_punch", require: false
gem "delayed_job", require: false
gem "queue_classic", github: "QueueClassic/queue_classic", branch: "master", require: false, platforms: :ruby
gem "queue_classic", github: "Kjarrigan/queue_classic", branch: "update-pg", require: false, platforms: :ruby
gem "sneakers", require: false
gem "que", require: false
gem "backburner", require: false
Expand Down
14 changes: 7 additions & 7 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
GIT
remote: https://github.com/QueueClassic/queue_classic.git
revision: cde82d17ded2799ed726dd7b0df6ce1fd4c1b7da
branch: master
remote: https://github.com/Kjarrigan/queue_classic.git
revision: dee64b361355d56700ad7aa3b151bf653a617526
branch: update-pg
specs:
queue_classic (3.2.0.RC1)
pg (>= 0.17, < 0.20)
pg (>= 0.17, < 2.0)

GIT
remote: https://github.com/matthewd/rb-inotify.git
Expand Down Expand Up @@ -231,9 +231,9 @@ GEM
parallel (1.12.0)
parser (2.4.0.0)
ast (~> 2.2)
pg (0.19.0)
pg (0.19.0-x64-mingw32)
pg (0.19.0-x86-mingw32)
pg (1.0.0)
pg (1.0.0-x64-mingw32)
pg (1.0.0-x86-mingw32)
powerpack (0.1.1)
psych (2.2.4)
public_suffix (2.0.5)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
gem "pg", "~> 0.18"
gem "pg", ">= 0.18", "< 2.0"
require "pg"
require "thread"

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Make sure we're using pg high enough for type casts and Ruby 2.2+ compatibility
gem "pg", "~> 0.18"
gem "pg", ">= 0.18", "< 2.0"
require "pg"

require "active_record/connection_adapters/abstract_adapter"
Expand Down
2 changes: 1 addition & 1 deletion railties/lib/rails/generators/app_base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def gem_for_database
# %w( mysql postgresql sqlite3 oracle frontbase ibm_db sqlserver jdbcmysql jdbcsqlite3 jdbcpostgresql )
case options[:database]
when "mysql" then ["mysql2", [">= 0.3.18", "< 0.5"]]
when "postgresql" then ["pg", ["~> 0.18"]]
when "postgresql" then ["pg", [">= 0.18", "< 2.0"]]
when "oracle" then ["activerecord-oracle_enhanced-adapter", nil]
when "frontbase" then ["ruby-frontbase", nil]
when "sqlserver" then ["activerecord-sqlserver-adapter", nil]
Expand Down
2 changes: 1 addition & 1 deletion railties/test/generators/app_generator_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ def test_config_postgresql_database
if defined?(JRUBY_VERSION)
assert_gem "activerecord-jdbcpostgresql-adapter"
else
assert_gem "pg", "'~> 0.18'"
assert_gem "pg", "'>= 0.18', '< 2.0'"
end
end

Expand Down

0 comments on commit a9c06f6

Please sign in to comment.