Add preamble section #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ialarmedalien
commented
Aug 26, 2022
ialarmedalien
commented
Aug 26, 2022
ialarmedalien
commented
Aug 26, 2022
ialarmedalien
commented
Aug 26, 2022
ialarmedalien
commented
Aug 26, 2022
ialarmedalien
commented
Aug 26, 2022
bogdandm
requested changes
Aug 29, 2022
|
Thank you for this pr, seems good except for this small formatting bug. |
|
Do you want me to add a note to the changelog and bump the version too? |
|
No, the changelog is generated automatically and the version is updated with a single command (and the release is done by the github action). So I'll do it myself. |
|
@bogdandm change pushed |
bogdandm
approved these changes
Aug 31, 2022
|
Test fails now :( AttributeError: 'NoneType' object has no attribute 'strip' |
|
Should be fixed now, with another test added to ensure that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables extra matter to be added between the imports and the generated class list using a
--preamblecommand line parameter.I also fixed a few minor grammar bits and my IDE automatically removes trailing whitespace.
Closes #44