Skip to content

Conversation

DrTodd13
Copy link
Collaborator

Changes included in this PR

Drop_duplicates on dataframe now supports the subset and keep arguments.

Testing strategy

run_ci

User facing changes

Drop_duplicates now support subset and keep arguments.

Checklist

  • Pipelines passed before requesting review. To run CI you must include [run CI] in your commit message.
  • I am familiar with the Contributing Guide
  • I have installed + ran pre-commit hooks.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.92%. Comparing base (c33fbb5) to head (2826fd3).
⚠️ Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
+ Coverage   66.68%   68.92%   +2.23%     
==========================================
  Files         186      191       +5     
  Lines       66795    67137     +342     
  Branches     9507     9517      +10     
==========================================
+ Hits        44543    46274    +1731     
+ Misses      19572    18043    -1529     
- Partials     2680     2820     +140     

Copy link
Contributor

@IsaacWarren IsaacWarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DrTodd13

Copy link
Contributor

@scott-routledge2 scott-routledge2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DrTodd13

@DrTodd13 DrTodd13 merged commit 2f155ce into main Sep 29, 2025
26 checks passed
@DrTodd13 DrTodd13 deleted the todd/dropduplicates_subset branch September 29, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants