Remove exceptions on multiple * in dynamic names.

Per the finalized spec, these should be treated as lookup failures (i.e. rendered as empty strings) rather than exceptions.
bobthecow · Aug 23, 2022 · 93f824d · 93f824d
1 parent af4f8f7
commit 93f824d
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 34 deletions.
diff --git a/src/Mustache/Parser.php b/src/Mustache/Parser.php
@@ -313,12 +313,6 @@ private function getDynamicName(array $token)
             $isDynamic = true;
         }
 
-        // Two stars is two many!
-        if (preg_match('/^\s*\*\s*/', $name) || preg_match('/[|.]\s*\*/', $name)) {
-            $msg = sprintf('Invalid dynamic name: %s', $name);
-            throw new Mustache_Exception_SyntaxException($msg, $token);
-        }
-
         return array($name, $isDynamic);
     }
 

diff --git a/test/Mustache/Test/Functional/DynamicPartialsTest.php b/test/Mustache/Test/Functional/DynamicPartialsTest.php
@@ -24,34 +24,6 @@ public function setUp()
         ));
     }
 
-    public function getInvalidDynamicNamesExamples()
-    {
-        return array(
-            array('{{> **foo}}'),
-            array('{{> *foo.*bar}}'),
-            array('{{> foo.*bar}}'),
-            array('{{ *foo }}'),
-            array('{{{ *foo }}}'),
-            array('{{& *foo }}'),
-            array('{{# *foo }}{{/ *foo }}'),
-            array('{{^ *foo }}{{/ *foo }}'),
-            array('{{% FILTERS}}{{> *foo | *bar}}'),
-            array('{{% FILTERS}}{{> foo | *bar}}'),
-            array('{{% BLOCKS }}{{$ *foo }}{{/ *foo }}'),
-        );
-    }
-
-    /**
-     * @dataProvider getInvalidDynamicNamesExamples
-     * @expectedException Mustache_Exception_SyntaxException
-     * @expectedExceptionMessage Invalid dynamic name:
-     */
-    public function testInvalidDynamicNamesExamples($template)
-    {
-        $this->mustache->render($template);
-    }
-
-
     public function getValidDynamicNamesExamples()
     {
       // technically not all dynamic names, but also not invalid