Throw syntax exception for unclosed tags.

Fixes #395
bobthecow · Jul 28, 2022 · 64e5609 · 64e5609
1 parent c971867
commit 64e5609
Show file tree

Hide file tree

Showing 2 changed files with 70 additions and 0 deletions.
diff --git a/src/Mustache/Tokenizer.php b/src/Mustache/Tokenizer.php
@@ -215,6 +215,10 @@ public function scan($text, $delimiters = '')
             }
         }
 
+        if ($this->state !== self::IN_TEXT) {
+            $this->throwUnclosedTagException();
+        }
+
         $this->flushBuffer();
 
         // Restore the user's encoding...
@@ -279,6 +283,10 @@ private function changeDelimiters($text, $index)
         $close      = '=' . $this->ctag;
         $closeIndex = strpos($text, $close, $index);
 
+        if ($closeIndex === false) {
+            $this->throwUnclosedTagException();
+        }
+
         $token = array(
             self::TYPE => self::T_DELIM_CHANGE,
             self::LINE => $this->line,
@@ -333,6 +341,10 @@ private function setDelimiters($delimiters)
     private function addPragma($text, $index)
     {
         $end    = strpos($text, $this->ctag, $index);
+        if ($end === false) {
+            $this->throwUnclosedTagException();
+        }
+
         $pragma = trim(substr($text, $index + 2, $end - $index - 2));
 
         // Pragmas are hoisted to the front of the template.
@@ -344,4 +356,23 @@ private function addPragma($text, $index)
 
         return $end + $this->ctagLen - 1;
     }
+
+    private function throwUnclosedTagException()
+    {
+        $name = trim($this->buffer);
+        if ($name !== '') {
+            $msg = sprintf('Unclosed tag: %s on line %d', $name, $this->line);
+        } else {
+            $msg = sprintf('Unclosed tag on line %d', $this->line);
+        }
+
+        throw new Mustache_Exception_SyntaxException($msg, array(
+            self::TYPE  => $this->tagType,
+            self::NAME  => $name,
+            self::OTAG  => $this->otag,
+            self::CTAG  => $this->ctag,
+            self::LINE  => $this->line,
+            self::INDEX => $this->seenTag - $this->otagLen,
+        ));
+    }
 }
diff --git a/test/Mustache/Test/TokenizerTest.php b/test/Mustache/Test/TokenizerTest.php
@@ -351,4 +351,43 @@ public function getTokens()
             ),
         );
     }
+
+    /**
+     * @dataProvider getUnclosedTags
+     * @expectedException Mustache_Exception_SyntaxException
+     */
+    public function testUnclosedTagsThrowExceptions($text)
+    {
+        $tokenizer = new Mustache_Tokenizer();
+        $tokenizer->scan($text, null);
+    }
+
+    public function getUnclosedTags()
+    {
+        return array(
+            array('{{ name'),
+            array('{{ name }'),
+            array('{{{ name'),
+            array('{{{ name }'),
+            array('{{& name'),
+            array('{{& name }'),
+            array('{{# name'),
+            array('{{# name }'),
+            array('{{^ name'),
+            array('{{^ name }'),
+            array('{{/ name'),
+            array('{{/ name }'),
+            array('{{> name'),
+            array('{{< name'),
+            array('{{> name }'),
+            array('{{< name }'),
+            array('{{$ name'),
+            array('{{$ name }'),
+            array('{{= <% %>'),
+            array('{{= <% %>='),
+            array('{{= <% %>=}'),
+            array('{{% name'),
+            array('{{% name }'),
+        );
+    }
 }