Download and cache windows server ISO to preloads folder #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobsira
changed the title
spowelljr
suggested changes
Jul 18, 2024
spowelljr
reviewed
Jul 18, 2024
iankingori
reviewed
Aug 1, 2024
iankingori
reviewed
Aug 1, 2024
iankingori
reviewed
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require a windows server ISO to install windows for the windows node. This PR addresses the efforts of downloading the windows iso and caching it on demand!
This PR has two triggers to download the windows iso
Example below which triggers the ISO download
Test this PR by running any of the above commands and you should observe windows server 2022 ISO(which is the OS we currently support) in the
.minikube>cache>iso>amd64folderWindows Node Support in minikube Proposal