This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Upgrade complete implementation of LinkedList #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Podolian
changed the title
tboychuk
reviewed
Oct 20, 2018
| } | ||
|
|
||
| private Node<E> findTail() { | ||
| Node<E> followingNode = Objects.requireNonNull(head); |
There was a problem hiding this comment.
Why did you name it followingNode?
There was a problem hiding this comment.
I shouldn't name it so.
Changing that variable name to currentNode.
| return LookForElement(element); | ||
| } | ||
|
|
||
| private boolean LookForElement(E element) { |
There was a problem hiding this comment.
It's not the best name for method. It does not follow naming convention. In addition, it would be better to put this code into method contains()
There was a problem hiding this comment.
Yes, moving code to contains() method.
|
|
||
| @Test | ||
| public void testAddElement() { | ||
| testLinkedList.add(7); |
There was a problem hiding this comment.
Let's use BUILD OPERATE ASSERT pattern for test methods. E.g. you separate three parts of a test using empty line.
There was a problem hiding this comment.
Applying the pattern.
…ode` - move `LookForElement()` code to method `contains()` and delete `LookForElement()` method - apply BUILD OPERATE ASSERT pattern to `LinkedListTest`
tboychuk
approved these changes
Oct 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.