Update tarjan_test.cpp

[hxm-cpp]

std::sort fix

[github-actions]

Hi there! Thank you for creating your first pull-request on the Graaf library :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (5b47687) to head (1e8c25b).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          56       56           
  Lines        2586     2586           
  Branches      135      135           
=======================================
  Hits         2575     2575           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bobluppes]

Hi @hxm-cpp, thanks for opening this PR!

It is indeed preferred to explicitly include the headers which are used, as opposed to including these transitively. Out of interest, did you have any issues building the tests without this include?

[github-actions]

Marking this PR as stale. It will not be automatically closed.

Even though the maintainers of Graaf may not always have time to take a look in a timely fashion, your contributions are much appreciated.
Please allow some time for @bobluppes to take a closer look.

[github-actions]

Marking this PR as stale. It will not be automatically closed.

Even though the maintainers of Graaf may not always have time to take a look in a timely fashion, your contributions are much appreciated.
Please allow some time for @bobluppes to take a closer look.

[FlorianXXIV]

Hi @hxm-cpp, thanks for opening this PR!

It is indeed preferred to explicitly include the headers which are used, as opposed to including these transitively. Out of interest, did you have any issues building the tests without this include?

Hey @bobluppes since you never recieved an awnser for this, at least for me, using cmake --build . did give me an error because id didn't find std::sort, after including algorithm in tarjan.h (i did that in #217 since I didn't see this merge request) the project built without issues.

[bobluppes]

Hi @hxm-cpp, thanks for opening this PR!
It is indeed preferred to explicitly include the headers which are used, as opposed to including these transitively. Out of interest, did you have any issues building the tests without this include?

Hey @bobluppes since you never recieved an awnser for this, at least for me, using cmake --build . did give me an error because id didn't find std::sort, after including algorithm in tarjan.h (i did that in #217 since I didn't see this merge request) the project built without issues.

Hi @FlorianXXIV, thanks for confirming! I was now able to reproduce this locally as well, not sure why this was broken before though. I will merge this PR after which I can rebase yours 👍🏻