Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Gutenberg 12.5.3 and WordPress 5.9 #35

Open
bobbingwide opened this issue Jan 20, 2022 · 6 comments
Open

Update for Gutenberg 12.5.3 and WordPress 5.9 #35

bobbingwide opened this issue Jan 20, 2022 · 6 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Jan 20, 2022

Apply similar changes to thisis as for Fizzie. See bobbingwide/fizzie#72
And also take a look at things done in ccd2022

Problems are that it now "Looks funny"

  • Everything is Full width
  • Margins appear to have disappeared
  • Background colour missing elsewhere

I should also be able to make use of the Row variation of the Group block.

@bobbingwide bobbingwide self-assigned this Jan 20, 2022
@bobbingwide
Copy link
Owner Author

The first major problem I had was of my own doing.

Problem

I lost the ability to toggle Inherit default layout; the toggle was missing.

Explanation

  • I'd duffed up theme.json when copying the custom.spacing section from Twenty Twenty Two.
  • The curly braces ended up in the wrong place.
  • I inadvertently changed settings.layout to settings.custom.layout
  • Which, I assume, meant that there wasn't a default layout to inherit

@bobbingwide
Copy link
Owner Author

But I also noticed nearly 200 messages in the console log

VM999 react_devtools_backend.js:4045 Error while traversing the CSS: Error: undefined:81:4: property missing ':'

@bobbingwide
Copy link
Owner Author

I decided to add my WordPress info block into the footer area.
But....

  1. It doesn't align center under the images
  2. When I tried converted a Columns block into 3 columns I lost the ability to set the second and third column's width using percentages.

@bobbingwide
Copy link
Owner Author

Having renamed the block-templates and block-template-parts folders I've broken the special internationalisation logic in the template-part.php overrides. A quick fix is to disable this override. An alternative is to change the code to look for /parts/ instead of /block-template-parts/

@bobbingwide
Copy link
Owner Author

I don't know value to use for settings.spacing.blockGap.

  • If I set it to 0 then there's no margin between columns.
  • If I set it to 0.5rem then there's vertical white space between the header and the Cover block
    due to the generated CSS
.wp-site-blocks > * + * {
    margin-top: var( --wp--style--block-gap );
}

@bobbingwide bobbingwide changed the title Update for Gutenberg 12.4.0 and WordPress 5.9 Update for Gutenberg 12.5.3 and WordPress 5.9 Feb 8, 2022
@bobbingwide bobbingwide added enhancement New feature or request bug Something isn't working labels Feb 8, 2022
@bobbingwide
Copy link
Owner Author

A pragmatic solution to the width problem is to set the contentSize and wideSize to the same values.
eg increase contentSize from 800px to 1200px.

bobbingwide added a commit that referenced this issue Feb 8, 2022
bobbingwide added a commit that referenced this issue Feb 8, 2022
bobbingwide added a commit that referenced this issue Feb 8, 2022
bobbingwide added a commit that referenced this issue Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant