Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subgraph endpoints #1394

Merged
merged 18 commits into from
May 21, 2024
Merged

Update subgraph endpoints #1394

merged 18 commits into from
May 21, 2024

Conversation

boyuan-chen
Copy link
Contributor

@boyuan-chen boyuan-chen commented May 16, 2024

📋 Add associated issues, tickets, docs URL here.

Overview

Describe what your Pull Request is about in a few sentences.

Update the subgraph endpoints to Graph Studio.

Graph Studio provides two endpoints. One is for development, which is free. The other requires your own API key. If the API key is not provided in the .env file or environment, we will use the development endpoint.

Changes

Describe your changes and implementation choices. More details make PRs easier to review.

  • Update subgraph endpoints
  • Clean up the code
  • The BNB local network is replaced by the Geth client for the integration test. Somehow, CircleCI doesn’t work with the BNB local network.

Testing

Describe how to test your new feature/bug fix and if possible, a step by step guide on how to demo this.

Updated the unit tests

Copy link

@jyellick jyellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Ordinarily I'd push back on the broken pieces of CI, but as we're phasing this codebase out, I think the more tactical solution makes sense.

Copy link
Contributor

@souradeep-das souradeep-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@boyuan-chen boyuan-chen merged commit 7f23de1 into develop May 21, 2024
9 of 12 checks passed
@boyuan-chen boyuan-chen deleted the update-subgraph-endpoints branch May 21, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants